Skip to content

[v7r2] Remove pyGSI#4481

Merged
fstagni merged 1 commit into
DIRACGrid:integrationfrom
chrisburr:bye-bye-py-gsi
May 5, 2020
Merged

[v7r2] Remove pyGSI#4481
fstagni merged 1 commit into
DIRACGrid:integrationfrom
chrisburr:bye-bye-py-gsi

Conversation

@chrisburr

@chrisburr chrisburr commented Mar 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

BEGINRELEASENOTES

*Core
CHANGE: Remove pyGSI support

ENDRELEASENOTES

Closes #4272
Includes #4490

@chrisburr

chrisburr commented Mar 5, 2020

Copy link
Copy Markdown
Member Author

This will now fail with the same issue as #4461 but other than that it's ready.

@chrisburr chrisburr marked this pull request as ready for review March 5, 2020 14:41
chrisburr
chrisburr commented Mar 5, 2020
View reviewed changes
Comment thread environment.yml
@chrisburr chrisburr mentioned this pull request Mar 5, 2020
Merged
andresailer
andresailer reviewed Mar 27, 2020
View reviewed changes
Comment thread docs/source/AdministratorGuide/technologyPreviews.rst
@chrisburr

chrisburr commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

This is still blocked by #4469

@fstagni

fstagni commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

pylint fails:

************* Module X509Request
Core/Security/pygsi/X509Request.py:6: [E0401(import-error), ] Unable to import 'GSI'
Core/Security/pygsi/X509Request.py:9: [E0611(no-name-in-module), ] No name 'pygsi' in module 'DIRAC.Core.Security'
Core/Security/pygsi/X509Request.py:9: [E0401(import-error), ] Unable to import 'DIRAC.Core.Security.pygsi.X509Chain'
************* Module X509CRL
Core/Security/pygsi/X509CRL.py:11: [E0401(import-error), ] Unable to import 'GSI'
##[error]Process completed with exit code 1.

@chrisburr

chrisburr commented Apr 23, 2020

Copy link
Copy Markdown
Member Author

pylint fails:

************* Module X509Request
Core/Security/pygsi/X509Request.py:6: [E0401(import-error), ] Unable to import 'GSI'
Core/Security/pygsi/X509Request.py:9: [E0611(no-name-in-module), ] No name 'pygsi' in module 'DIRAC.Core.Security'
Core/Security/pygsi/X509Request.py:9: [E0401(import-error), ] Unable to import 'DIRAC.Core.Security.pygsi.X509Chain'
************* Module X509CRL
Core/Security/pygsi/X509CRL.py:11: [E0401(import-error), ] Unable to import 'GSI'
##[error]Process completed with exit code 1.

It's been rebased too many times. I need to remove pyGSI from scratch again.

@chrisburr
Remove pyGSI
270784e 
Force OpenSSL < 1.1

Remove SSLSocketFactory

Restore pytest.ini

M2Crypto: run M2crypto tests before pyGSI tests to avoid openSSL internal memory

M2Crypto: isVOMS tested with OID rather than X509v3 extension name 'vomsExtensions'
@chrisburr

chrisburr commented May 5, 2020

Copy link
Copy Markdown
Member Author

This is ready to merge now

@zmathe zmathe mentioned this pull request May 5, 2020
Closed
@fstagni fstagni merged commit 1694fc7 into DIRACGrid:integration May 5, 2020
@fstagni

fstagni commented May 8, 2020

Copy link
Copy Markdown
Contributor

Just a comment on pyGSI and diracdoctools: since this PR is merged, IIUC DIRAC/docs/diracdoctools/fakeEnvironment.py can be removed @andresailer

@chrisburr chrisburr deleted the bye-bye-py-gsi branch May 8, 2020 09:14
@chrisburr chrisburr mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andresailer andresailer andresailer left review comments
@chaen chaen chaen left review comments
@fstagni fstagni fstagni approved these changes
@atsareg atsareg Awaiting requested review from atsareg atsareg is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

M2Crypto as default, and remove pyGSI

4 participants

@chrisburr @fstagni @andresailer @chaen